Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #14426: Makes all Manufacturer links dynamic, not just warranty lookup #14530

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

DrekiDegga
Copy link

Description

As requested in #14470, I'm retargeting for develop branch. I couldn't find an easy way to do this so I just started over. Deleted, reforked, made changes against the develop branch and retested on testing environment with debugging enabled.

This makes all manufacturer links dynamic just like warranty lookup.

Added #14426

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've tested working on latest from my test environment.

Test Configuration:

  • PHP version: 7.4.33
  • MySQL version 10.11.4-MariaDB-1~deb12u1 Debian 12
  • Webserver version apache2 2.4.56-1~deb11u2
  • OS version Debian 12

Checklist:

Copy link

what-the-diff bot commented Apr 1, 2024

PR Summary

  • Extension of URL Validation Range
    Manufacturers URLs can now start with a variety of protocols, such as http://, https://, afp://, facetime://, file://, or irc://. This increased valid startings gives more flexibility to input URLs for manufacturers.

  • Method Renaming and Updating
    The method previously named dynamicWarrantyUrl() is now dynamicUrl(), and it has been enhanced to be more flexible. It now takes a parameter to replace placeholders with user intending values, thereby increasing its usability.

  • Updates in Asset's Display Page

    • We have improved how we handle URLs in the display page. Now, we are checking whether the URL is not empty, instead of it merely not being null.
    • The displayed links for the manufacturer's URL, support URL, and warranty lookup URL are dynamically generated now for more accuracy and consistency. External link icons have been added next to these URLs for a better visual cue.

@DrekiDegga DrekiDegga requested a review from snipe April 4, 2024 15:39
@DrekiDegga
Copy link
Author

Please let me know if there's a better way to do this or if there's anything else I can do to get this merged. @snipe

Thanks.

@DrekiDegga
Copy link
Author

Here's a screenshot of this currently working on my test environment.
image

I've made no changes to the font icons or accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants