Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed user assets not updating when a user changes location #14474

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

Description

I'm not sure how this came to break. but I noticed we are passing a $request value in the asset update instead of the $user->location_id. Assets resync to location updates.

Fixes #14439

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner March 21, 2024 22:21
Copy link

what-the-diff bot commented Mar 21, 2024

PR Summary

  • Change in AssetCheckoutController.php
    The way the system decides where to check an asset out to has been altered. Instead of getting that information directly, it's now determined by a special set of rules defined in a method called determineCheckoutTarget().

  • Update in UsersController.php
    When an asset's location requires updating, the system now gets this information from the user's own location details, replacing the previous method where it was coming from incoming request data. This new change ensures the asset's location is more closely tied to where the user is actually located.

@snipe
Copy link
Owner

snipe commented May 2, 2024

Looks like we have some conflicts now - can you handle those real quick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants