Adds a note text area to asset acceptances/declines

[Godmartinz]

Description

Adds a note text area to allow a user to give more detail when accepting/decling an asset. The note is saved in the checkout_acceptances table.

It only appears if you select the decline radio button.

The mail notification also reflects the notes shared by the user when declined

The mail notification also reflects the notes shared by the user when accepted

The notes are also reflected in the action log

Fixes #[SC-25074]

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• [ x] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Test Configuration:

• PHP version:
• MySQL version
• Webserver version
• OS version

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Addition of a New Field for the Checkout Acceptance Model
  A field labeled 'declined_msg' has been inserted into the database table of CheckoutAcceptance. This will be employed to record any supplementary notes or remarks when a checkout acceptance is declined.

• Updates on the Acceptance Controller
  The 'declined_msg' is also included in the set of data being sent to the view via the AcceptanceController.

• Enhancements on the Acceptance Asset Declined Notification
  Simultaneously, adjustments have been made to the AcceptanceAssetDeclinedNotification to encompass the mentioned 'declined_msg' in its constructor and mailing methodologies. This message will be included in the notification template as well.

• Implementation of New Migration
  A new migration has been brought to life to include the 'declined_msg' column in the checkout_acceptances database table.

• Embedding a New Translation Key
  A fresh translation key for 'decline_msg' is added to the general.php language file, facilitating multilingual support.

• Changes in the Blade PHP View
  create.blade.php view has been fitted with a new textarea input 'declined_msg'. This input will only appear when the 'declined' checkbox is marked.

• Updates on the Email Template
  The asset-acceptance.blade.php email template has been amended to consist of the declined message, should there be one.

[marcusmoore]

I'll help out with those sqlite test failures.

[marcusmoore]

One change should fix the failing tests.

[marcusmoore]

One question for @snipe / @uberbrady (who know databases better than I do) and a couple notes that don't need to hold up the PR.

(Marking as "request changes" just so the red is more noticeable)

[snipe]

This looks good - should we maybe consider making this slightly more generic, so it's just a note, not specifically a declined note? I can't think of a reason why you'd want a note with an acceptance, but since we're already doing all the work anyway, we could probably just make it a note, regardless of whether it's a decline or acceptance. (Also can we make that text area width be the width of that panel?)

[snipe]

A few questions/comments in the previous comment.

[Godmartinz]

@snipe changes have been applied. 👍

[marcusmoore]

Changing it a generic note makes sense to me. A couple things to address though.

[shortcut-integration]

This pull request has been linked to Shortcut Story #25074: Add a note to the decline screen.

[marcusmoore]

I haven't looked at why yet but notes aren't being stored when an asset is accepted

[marcusmoore]

Some changes por favor

[marcusmoore]

One more final change...sorry 😅

[marcusmoore]

Looks good! 👍🏾