Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Assets location not being resynced when Users location is updated via LDAP #14441

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Mar 17, 2024

Description

While syncing, if a user's location is update via LDAP this change now will grab all Assets that are assigned to the user and update their location as intended.
[SC-23242]
Fixes #

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Mar 17, 2024

PR Summary

  • Asset Model Association Established
    The code now has an added reference to the 'Asset' model. This is like giving the code a map to know where to find and interact with assets, which are crucial components of the software.

  • Improvements to Location ID Updating
    Whenever an asset is assigned to a user during the procedure known as LDAP synchronization, the software now will also update the 'location_id'. This means the system will be able to better track where assets have been allocated, providing better organization and efficiency.

@Godmartinz Godmartinz marked this pull request as ready for review March 19, 2024 18:59
@Godmartinz Godmartinz requested a review from snipe as a code owner March 19, 2024 18:59
Copy link

@Godmartinz Godmartinz requested a review from snipe March 21, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants