Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds quantity of accessories and consumables to checkout. #14342

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Feb 27, 2024

Description

This allows for users to checkout multiple Accessories and Consumables of the same type at the same time.
image
image

Only one email is sent with a quantity listed.
image

The action log still logs each accessory or consumable checked out.

image

Checkins for accessories remains singular.

Fixes #7348

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

This pull request has been linked to Shortcut Story #9899: Checkout multiple consumables/accessories at once.

Copy link

what-the-diff bot commented Feb 27, 2024

PR Summary

  • Enhanced User-Accessory Interaction
    In AccessoryCheckoutController.php, a new feature was added that allows for multiple accessories to be linked to users based on specified quantities. In addition, an event is now initiated each time an attachment occurs which can be useful for tracking and logs.

  • Enhanced User-Consumable Interaction
    Similar to the accessories, the ConsumableCheckoutController.php now has a feature for attaching multiple consumables to users depending on the provided quantities. After each attachment, an event is also triggered for easy tracking.

  • User Interface Update for Accessories
    An update was made to the accessories directory's checkout.blade.php file. This update includes a new input field that enables users to specify the quantity of accessories they want to check out.

  • User Interface Update for Consumables
    Analogous to the accessories update, the consumables directory's checkout.blade.php file now has a new input field. This enables users to determine the quantity of consumables they intend to check out.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped in to check out the test failures and have some comments. Some small changes needed but almost there 👍🏾

resources/views/accessories/checkout.blade.php Outdated Show resolved Hide resolved
config/debugbar.php Outdated Show resolved Hide resolved
…-9899

# Conflicts:
#	app/Http/Controllers/Accessories/AccessoryCheckoutController.php
#	app/Http/Controllers/Consumables/ConsumableCheckoutController.php
@marcusmoore marcusmoore self-requested a review May 1, 2024 18:18
Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@Godmartinz
Copy link
Collaborator Author

@snipe all good here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants