Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout Type can somehow sometimes be empty #14134

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

spencerrlongg
Copy link
Collaborator

@spencerrlongg spencerrlongg commented Jan 16, 2024

Description

Early WIP

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.2

Copy link

This pull request has been linked to Shortcut Story #24173: Checkout Type can somehow sometimes be empty.

Copy link

what-the-diff bot commented Jan 16, 2024

PR Summary

  • Removal of assigned_to field in StoreAssetRequest.php
    The assigned_to field, previously included in a combining operation in the prepareForValidation function, has been removed. This alteration simplifies the validation process.

  • Conditional Check added in AssetObserver.php
    A clause was introduced in AssetObserver.php to check the existence of assigned_to in $attributesOriginal. This correction ensures the proper functioning of the store method in Api/AssetsController - improving our API's reliability and performance.

@snipe snipe changed the title bug/sc-24173 Checkout Type can somehow sometimes be empty Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant