Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes creating invalid query with null values #14101

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR adds a guard against adding a null value to the query and subsequently throwing an exception upon the execution of that query.

Having a custom field with a null db_column can cause this error since $request->filled(null) is truthy.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Since $request->filled(null) returns true
Copy link

what-the-diff bot commented Jan 4, 2024

PR Summary

  • Enhanced Search Functionality in AssetsController
    This update adds an additional verification step in the AssetsController. This means the system will now verify if there is identifiable information before applying any search filters. This improved logic ensures more relevant search results and prevents potential errors or inconsistencies.

@snipe snipe merged commit dbcf7e3 into snipe:develop Jan 4, 2024
7 checks passed
@marcusmoore marcusmoore deleted the bug/sc-24398 branch January 4, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants