Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceling jobs through Snakemake profiles? #570

Closed
holtgrewe opened this issue Aug 17, 2020 · 2 comments · Fixed by #1395
Closed

Canceling jobs through Snakemake profiles? #570

holtgrewe opened this issue Aug 17, 2020 · 2 comments · Fixed by #1395
Labels
enhancement New feature or request

Comments

@holtgrewe
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  • When running cluster jobs through DRMAA, they are nicely canceled when Snakemake is stopped with Ctrl-C. This is not the case for the Slurm profile.

Describe the solution you'd like

  • Similarly to when running DRMAA cluster jobs, I'd like to have child jobs being killed (e.g., via scancel).

Describe alternatives you've considered

  • I don't think there are alternatives. I have not seen any mention of "canceling" in the Slurm or SURF profile.

Additional context

  • Maybe I'm missing something?
@percyfal
Copy link
Contributor

Hi @holtgrewe, I have just been reviewing a related bug report for the slurm profile (referenced above). Much of the solutions you request cannot be implemented in the profile itself, but would require modifications to the job executors, maybe even adding a specific SlurmExecutor; I believe there is an ongoing effort to refactor the executors. scancelling jobs should work, but whereas metadata for failed jobs is removed, incomplete files are not; see Persistence.cleanup. Adding a job.cleanup() statement here seems to fix that particular issue, but there may be a reason for it's absence that I'm unaware of.

@holtgrewe
Copy link
Contributor Author

Hi @percyfal thanks for your reply.

IMO it's borderline cheeky to mark --cluster/--drmaa support in Snakemake as deprecated without the profiles offering equivalent functionality. Well, the good is the enemy of the better. I'd dearly like to see profile support to reach the same level of features as --drmaa as using --time=7-00 is much nicer than saying --time=168:00:00...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants