Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--dry-run --quiet fails on 8 #2825

Closed
rueberger opened this issue Apr 18, 2024 · 0 comments · Fixed by #2829
Closed

--dry-run --quiet fails on 8 #2825

rueberger opened this issue Apr 18, 2024 · 0 comments · Fixed by #2829
Labels
bug Something isn't working

Comments

@rueberger
Copy link
Contributor

8.10.4

(snakemake) [a5b@sh02-07n33 ~] (job 45234363) $ snakemake --dry-run --quiet
Traceback (most recent call last):

  File "/home/users/a5b/venvs/snakemake/lib/python3.12/site-packages/snakemake/cli.py", line 1927, in args_to_api
    workflow_api = snakemake_api.workflow(
                   ^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/users/a5b/venvs/snakemake/lib/python3.12/site-packages/snakemake/api.py", line 141, in workflow
    self.setup_logger(mode=workflow_settings.exec_mode)

  File "/home/users/a5b/venvs/snakemake/lib/python3.12/site-packages/snakemake/api.py", line 250, in setup_logger
    setup_logger(

  File "/home/users/a5b/venvs/snakemake/lib/python3.12/site-packages/snakemake/logging.py", line 748, in setup_logger
    raise ValueError(

ValueError: Unsupported value provided for quiet mode (either bool, None or list allowed).

works in 7.32.4
@rueberger rueberger added the bug Something isn't working label Apr 18, 2024
@cademirch cademirch mentioned this issue Apr 20, 2024
Merged
2 tasks
johanneskoester pushed a commit that referenced this issue Apr 28, 2024
@cademirch
fix: return set instead of list when just --quiet (#2829)
eeb57e2 
### Description

Fixes #2825. `parse_quietness` should return a set since that is what
`setup_logger()` expects.

### QC
<!-- Make sure that you can tick the boxes below. -->

* [x] The PR contains a test case for the changes or the changes are
already covered by an existing test case.
* [x] The documentation (`docs/`) is updated to reflect the changes or
this is not necessary (e.g. if the change does neither modify the
language nor the behavior or functionalities of Snakemake).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: return set instead of list when just --quiet cademirch/snakemake
1 participant
@rueberger