New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs issue or regression? retries ignored #2047
Comments
This is a bug. The current implementation is not correctly handling Interestingly, such an experiment reveals a second bug, specifically related to the use of the I'll create a new issue for the second bug, using the adapted minimal example. |
The retries property of each rule was being set via the cli flag whenever the retries directive was falsy. This was leading `retries: 0` to be incorrectly overriden. Fix by explicitely checking for None Resolves snakemake#2047
The retries property of each rule was being set via the cli flag whenever the retries directive was falsy. This was leading `retries: 0` to be incorrectly overriden. Fix by explicitely checking for None Resolves snakemake#2047
The retries property of each rule was being set via the cli flag whenever the retries directive was falsy. This was leading `retries: 0` to be incorrectly overridden. Fix by explicitly checking for None Resolves snakemake#2047
The retries property of each rule was being set via the cli flag whenever the retries directive was falsy. This was leading `retries: 0` to be incorrectly overridden. Fix by explicitly checking for None Resolves #2047 ### QC <!-- Make sure that you can tick the boxes below. --> * [x] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [x] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
Snakemake version
7.19.1
Describe the bug
The rule-specific
retries
directive is ignored.Minimal example
Running the above with
will restart the failed rule 5 times.
Additional context
The way I understand the documentation ...
the
retries
directive in a rule should always take precedence.This is related to #1649 (and somewhat to #367 and #500)
The text was updated successfully, but these errors were encountered: