Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--quiet default not respected when --profile is used #1702

Closed
pvandyken opened this issue Jun 7, 2022 · 1 comment · Fixed by #1764
Closed

--quiet default not respected when --profile is used #1702

pvandyken opened this issue Jun 7, 2022 · 1 comment · Fixed by #1764
Labels
bug Something isn't working

Comments

@pvandyken
Copy link
Contributor

pvandyken commented Jun 7, 2022

Snakemake version
Any snakemake after #1649

Describe the bug
If --quiet is used without an argument along with --profile, it is ignored. This occurs because the code setting quiet to ["progress", "rules"] when len(args.quiet) == 0 is placed before profile parsing.

if args.quiet is not None and len(args.quiet) == 0:
    # default case, set quiet to progress and rule
    args.quiet = ["progress", "rules"]

if args.profile:
    ...

It is fixed by moving it after the if args.profile: block.

Minimal example
Any snakemake workflow (e.g. the example on the docs site) with any profile should trigger the bug.

@pvandyken pvandyken added the bug Something isn't working label Jun 7, 2022
@pvandyken
Copy link
Contributor Author

Just realized this bug was also noticed in #1660, apologies for the duplicate report. If my understanding of the problem is correct, I'm happy to make a patch PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant