fix: preserve dtypes across paramspace #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
approved these changes
Apr 21, 2022
johanneskoester
added a commit
that referenced
this pull request
Apr 21, 2022
This reverts commit 70ce6a0.
|
@SichongP the testcase fails after merging to main branch. Can you have a look? |
|
It was caused by the test case pushed by #1299 Should be fixed now @johanneskoester Would you be able to reopen this or do I need to open a new PR? |
|
thanks, I have pulled your changes in PR #1594! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #1574 where when int and float numbers are mixed in paramspace, they are coerced to floats. This is done by replacing
iterrowsinParamspace.instance_patterns()withitertuples.This also updates
test_paramspaceto include a mixed type paramspace (alpha is now int)QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).