Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for small files, compare checksums to determine if job needs to run if input file is newer than output file #1568

Merged
merged 9 commits into from May 12, 2022

Conversation

johanneskoester
Copy link
Contributor

Description

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

… run if input file is newer than output file
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Please format your code with black: black snakemake tests/*.py.

@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 1ae85c6 into main May 12, 2022
@johanneskoester johanneskoester deleted the checksum-fallback branch May 12, 2022 07:19
LarsStegemanGT pushed a commit to LarsStegemanGT/snakemake that referenced this pull request Jan 16, 2023
… run if input file is newer than output file (snakemake#1568)

* feat: for small files, compare checksums to determine if job needs to run if input file is newer than output file

* check local existence

* read file in binary mode

* fixed rewrite, now being output file based

* do not calculate checksum of directories

* fix: fix order of checksum eligibility test

* fixes

* skip reading of empty file for checksum creation

* allow forcing checksum generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant