Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.1.1 multicluster support breaks lsf profile #1481

Closed
ASLeonard opened this issue Mar 15, 2022 · 4 comments
Closed

v7.1.1 multicluster support breaks lsf profile #1481

ASLeonard opened this issue Mar 15, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ASLeonard
Copy link
Contributor

The changes made by #1459 break cluster execution using the "lsf" profile created by @mbhall88. I'm slightly guessing here, but I think the change now quoting the argument "{statuscmd} '{jobid}'".format( causes the "lsf" profile to try and parse the jobid as ' ' which is not a base10 number and causes an error.

Simple fix is to change the lsf_status.py script here and the line below to split the argv[1] and use the first for jobid and second for log. (Pull request here)

It is probably impossible to test-case every cluster profile, so not sure if this can be realistically avoided in the future.

@ASLeonard ASLeonard added the bug Something isn't working label Mar 15, 2022
@johanneskoester
Copy link
Contributor

@mbhall88 any thoughts about this?

@mbhall88
Copy link
Member

Best to continue the discussion on Snakemake-Profiles/lsf#46 I think

@ASLeonard
Copy link
Contributor Author

Effectively resolved through Snakemake-Profiles/lsf#47

@jdblischak
Copy link
Contributor

My apologies for inadvertently breaking the LSF profile! I didn't know that LSF passed the log file along with the job ID. Glad to see you were able to so quickly identify and fix the problem though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants