fix: issue #1257 (missing logfile failure when using shadow directory) #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses gh snakemake#1257. If the rule did not create a logfile, an empty one would be created in its final destination. If the shadow directive was used, however, Snakemake would try to move the nonexistent logfile from the shadow directory to its final location. This caused the observed failures. This commit has Snakemake create the empty file where Snakemake would have expected the program to create it (i.e. in the shadow directory). This enables the unshadow operation that takes place later to succeed.
jaicher
changed the title
…ling; fix existence check
johanneskoester
approved these changes
Nov 26, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test_shadowed_logthat demonstrates the failure case with issue Job failure with shadow directive if log files not created #1257snakemake.dag.unshadow_output(...)to successfully copy the logfile from the shadow directory to its final destination.QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).