fix: caching process #1225
Merged
fix: caching process #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
mbargull
reviewed
Oct 21, 2021
| wrapper.get_script(job.rule.wrapper, prefix=workflow.wrapper_prefix), | ||
| wrapper.get_script( | ||
| job.rule.wrapper, | ||
| sourcecahce=job.rule.workflow.sourcecache, |
There was a problem hiding this comment.
Small typo:
Suggested change
| sourcecahce=job.rule.workflow.sourcecache, | |
| sourcecache=job.rule.workflow.sourcecache, |
. Apparently the test suite didn't catch this -- @jafors, could you add a test so we could get coverage here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in caching of rules. First, it adds an encoding step in
hash.pywhich is required before updating the cache.Second, it adds the sourcecache argument to the call of
wrapper.get_script()in thehash.pyQC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).