docs: Mention required openssl dep for rust-script #1216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/snakemake/snakemake/blob/v6.9.1/snakemake/script.py#L1142 needs the
json_typegen
Crate which pulls in ( https://github.com/evestera/json_typegen/blob/v0.7.0/json_typegen/Cargo.toml#L19 ) its own library/Cratejson_typegen_shared
and that one by its default features pulls inreqwest
( https://github.com/evestera/json_typegen/blob/v0.7.0/json_typegen_shared/Cargo.toml#L24 ) which further down the road depends on OpenSSL (seecargo tree
forjson_typegen
for the dependency tree).So, OpenSSL is not a
rust-script
dependency here, but one that Snakemake-generated Rust "scripts" need.We should also ask (i.e., issue or if possible PR) the
json_typegen
maintainers to propagatejson_typegen_shared
feature selection tojson_typegen
, i.e., ask to add a feature tojson_typegen
to deactivatejson_typegen_shared
'sremote-samples
feature (possibly also the other default featureslocal-samples
,then; but those don't concern the OpenSSL problem here).option-parsing
QC
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).