feat: Add shadow: "copy-minimal" directive
#1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"copy-minimal" is similar to "minimal", but it creates copies instead of symlinks of the files. This makes it possible to use local hard disks of a node in a cluster. See snakemake#1152 for motivation and further explanation. Closes snakemake#1152
sebschmi
force-pushed
the
pull_request_1152
branch
from
120e43c
to
04520e3
Compare
sebschmi
changed the title
shadow: "copy-minimal" directive.shadow: "copy-minimal" directive
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
approved these changes
Aug 27, 2021
|
Good idea! |
|
Big thanks for this feature, I've dreamed for such a feature. That will so much help our use case! (currently I have a jury-rigged rsync-based solution ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"copy-minimal" is similar to "minimal", but it creates copies instead of symlinks of the files. This makes it possible to use local hard disks of a node in a cluster.
Description
See #1152 for motivation and further explanation.
I implemented the feature and added tests and documentation.
The test is a simple copy of the
test_shadowtest, removing all non-minimal parts and changing the minimal parts to copy-minimal, as well as testing if the files are physical copies instead of symlinks in the rules.In the documentation I simply searched for "shadow" and added the description about the new feature at the necessary places.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).