Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid spurious KeyError when handling FileNotFoundError in input functions. #1138

Merged
merged 1 commit into from Aug 17, 2021

Conversation

johanneskoester
Copy link
Contributor

Description

Input functions that throw a FileNotFoundError could have let to a KeyError when handling the exception.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@johanneskoester johanneskoester changed the title fix: key error when handling FileNotFoundError in input functions. fix: avoid spurious KeyError when handling FileNotFoundError in input functions. Aug 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit d25f04d into main Aug 17, 2021
@johanneskoester johanneskoester deleted the fix-input-function-exception-check branch August 17, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant