Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to set output type, vcf or gvcf. #476

Merged
merged 9 commits into from May 5, 2022

Conversation

Smeds
Copy link
Contributor

@Smeds Smeds commented Apr 19, 2022

Description

Make it possible to set if a vcf or gvcf will be outputted from the wrapper

QC

  • there is a test case which covers any introduced changes,
  • input: and output: file paths in the resulting rule can be changed arbitrarily,
  • either the wrapper can only use a single core, or the example rule contains a threads: x statement with x being a reasonable default,
  • rule names in the test case are in snake_case and somehow tell what the rule is about or match the tools purpose or name (e.g., map_reads for a step that maps reads),
  • all environment.yaml specifications follow the respective best practices,
  • wherever possible, command line arguments are inferred and set automatically (e.g. based on file extensions in input: or output:),
  • all fields of the example rules in the Snakefiles and their entries are explained via comments (input:/output:/params: etc.),
  • stderr and/or stdout are logged correctly (log:), depending on the wrapped tool,
  • temporary files are either written to a unique hidden folder in the working directory, or (better) stored where the Python function tempfile.gettempdir() points to (see here; this also means that using any Python tempfile default behavior works),
  • the meta.yaml contains a link to the documentation of the respective tool or command,
  • Snakefiles pass the linting (snakemake --lint),
  • Snakefiles are formatted with snakefmt,
  • Python wrapper scripts are formatted with black.

@Smeds Smeds force-pushed the update-output-haplotype-caller branch from 56285ce to 39075ac Compare April 19, 2022 12:37
@Smeds
Copy link
Contributor Author

Smeds commented Apr 19, 2022

conde refused to setup if I didn't lock mamba version to 0.15.3

@Smeds Smeds requested a review from fgvieira April 19, 2022 13:13
@johanneskoester
Copy link
Contributor

Can you revert your hotfix for the setup? I have just merged fixes to the CI config.

@Smeds
Copy link
Contributor Author

Smeds commented Apr 25, 2022

Can you revert your hotfix for the setup? I have just merged fixes to the CI config.

should only be changes to the wrapper left

@fgvieira fgvieira merged commit e62744d into snakemake:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants