New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented handling of memory constraints in fasterq-dump wrapper #432
Conversation
Would it make sense to have the |
Yes that would be awesome, thanks! |
Done, but feel free to change whatever you see fit. PS - could you also take a look at the other PRs? thanks, |
Thanks a lot, all merged and released as 0.3.0! |
Cool! I might make a new PR of this wrapper soon with the new wrapper-utils |
@johanneskoester could you update |
Description
QC
For all wrappers added by this PR, I made sure that
input:
andoutput:
file paths in the resulting rule can be changed arbitrarily,threads: x
statement withx
being a reasonable default,map_reads
for a step that maps reads),environment.yaml
specifications follow the respective best practices,input:
oroutput:
),Snakefile
s and their entries are explained via comments (input:
/output:
/params:
etc.),stderr
and/orstdout
are logged correctly (log:
), depending on the wrapped tool,tempfile.gettempdir()
points to (see here; this also means that using any Pythontempfile
default behavior works),meta.yaml
contains a link to the documentation of the respective tool or command,Snakefile
s pass the linting (snakemake --lint
),Snakefile
s are formatted with snakefmt,