Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated versions and fixes for samtools wrappers. #431

Merged
merged 10 commits into from Jan 18, 2022

Conversation

fgvieira
Copy link
Collaborator

@fgvieira fgvieira commented Jan 3, 2022

Description

QC

For all wrappers added by this PR, I made sure that

  • there is a test case which covers any introduced changes,
  • input: and output: file paths in the resulting rule can be changed arbitrarily,
  • either the wrapper can only use a single core, or the example rule contains a threads: x statement with x being a reasonable default,
  • rule names in the test case are in snake_case and somehow tell what the rule is about or match the tools purpose or name (e.g., map_reads for a step that maps reads),
  • all environment.yaml specifications follow the respective best practices,
  • wherever possible, command line arguments are inferred and set automatically (e.g. based on file extensions in input: or output:),
  • all fields of the example rules in the Snakefiles and their entries are explained via comments (input:/output:/params: etc.),
  • stderr and/or stdout are logged correctly (log:), depending on the wrapped tool,
  • temporary files are either written to a unique hidden folder in the working directory, or (better) stored where the Python function tempfile.gettempdir() points to (see here; this also means that using any Python tempfile default behavior works),
  • the meta.yaml contains a link to the documentation of the respective tool or command,
  • Snakefiles pass the linting (snakemake --lint),
  • Snakefiles are formatted with snakefmt,
  • Python wrapper scripts are formatted with black.

@fgvieira
Copy link
Collaborator Author

fgvieira commented Jan 3, 2022

I think the reason it is failing is because the two Snakefiles were renamed (its parent folder) and so cannot be found.

@johanneskoester johanneskoester changed the title Added proper tempdir and updated version feat: updated versions and fixes for samtools wrappers. Jan 17, 2022
@johanneskoester
Copy link
Contributor

Seems like bam2fq lacks a test Snakefile?

@fgvieira
Copy link
Collaborator Author

bam2fq is now called just fastq, so I did the same here; that is why it is complaining about a missing Snakefile for bam2fq.

@johanneskoester johanneskoester merged commit cbba82d into snakemake:master Jan 18, 2022
@fgvieira fgvieira deleted the bam2fq branch January 18, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants