Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added wrapper for bcftools stats #201

Merged
merged 8 commits into from Jan 26, 2022
Merged

feat: added wrapper for bcftools stats #201

merged 8 commits into from Jan 26, 2022

Conversation

williamrowell
Copy link
Contributor

Added bcftools stats subcommand wrapper.

johanneskoester
johanneskoester reviewed Nov 30, 2020
View reviewed changes
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Please add a test case with small test data and a corresponding function in test.py.

johanneskoester
johanneskoester requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@johanneskoester johanneskoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@williamrowell
Copy link
Contributor Author

I've updated this and added a test case. It's ready for review.

@johanneskoester johanneskoester changed the title added wrapper for bcftools stats feat: added wrapper for bcftools stats Jan 26, 2022
@johanneskoester johanneskoester merged commit 2caecb9 into snakemake:master Jan 26, 2022
@williamrowell williamrowell deleted the bcftools_stats branch January 30, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneskoester johanneskoester johanneskoester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@williamrowell @johanneskoester