Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated lockscreen notification and enum #1608

Merged
merged 7 commits into from Mar 31, 2020
Merged

Deprecated lockscreen notification and enum #1608

merged 7 commits into from Mar 31, 2020

Conversation

NicoleYarroch
Copy link
Contributor

@NicoleYarroch NicoleYarroch commented Mar 30, 2020 •
edited

Fixes #1601

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Fixed warnings in unit tests and built and ran existing unit tests.

Core Tests

Not needed as only deprecations were added.

Core version / branch / commit hash / module tested against: n/a
HMI name / version / branch / commit hash / module tested against: n/a

Summary

Deprecated the SDLOnLockScreenStatus notification and its corresponding notification name SDLDidChangeLockScreenStatusNotification as well as the SDLLockScreenStatus enum.

Changelog

Enhancements
  • Deprecated the SDLOnLockScreenStatus notification.

CLA

@NicoleYarroch
Deprecated lockscreen notifications
c028954 
Deprecated `SDLOnLockScreenStatus` and `SDLDidChangeLockScreenStatusNotification`
@NicoleYarroch NicoleYarroch self-assigned this Mar 30, 2020
@NicoleYarroch NicoleYarroch added the best practice Not a defect but something that should be improved anyway label Mar 30, 2020
@NicoleYarroch NicoleYarroch added this to In progress in v6.6.0 via automation Mar 30, 2020
@NicoleYarroch NicoleYarroch changed the title WIP: Deprecate lockscreen notification Deprecate lockscreen notification Mar 30, 2020
@NicoleYarroch NicoleYarroch changed the title Deprecate lockscreen notification WIP: Deprecate lockscreen notification Mar 30, 2020
@NicoleYarroch NicoleYarroch changed the title WIP: Deprecate lockscreen notification Deprecated lockscreen notification and enum Mar 31, 2020
v6.6.0 automation moved this from In progress to Reviewer approved Mar 31, 2020
@joeljfischer joeljfischer merged commit 2bf024a into develop Mar 31, 2020
v6.6.0 automation moved this from Reviewer approved to Done Mar 31, 2020
@joeljfischer joeljfischer deleted the bugfix/issue_1601_deprecate_lockscreen_notifications branch March 31, 2020 13:42
@NicoleYarroch NicoleYarroch mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

Assignees

@NicoleYarroch NicoleYarroch

Labels
best practice Not a defect but something that should be improved anyway
Projects
No open projects
v6.6.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NicoleYarroch @joeljfischer