Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SDLOnLockScreenStatus / SDLLockScreenStatus #1601

Closed
joeljfischer opened this issue Mar 25, 2020 · 3 comments
Closed

Deprecate SDLOnLockScreenStatus / SDLLockScreenStatus #1601

joeljfischer opened this issue Mar 25, 2020 · 3 comments
Assignees
Labels
best practice Not a defect but something that should be improved anyway
Projects

Comments

@joeljfischer
Copy link
Contributor

Bug Report

As part of a pre-lock screen manager lock screen solution, these fake RPCs were created. We should deprecate them so that we may remove them in the future.

@joeljfischer joeljfischer added the best practice Not a defect but something that should be improved anyway label Mar 25, 2020
@joeljfischer joeljfischer self-assigned this Mar 25, 2020
@NicoleYarroch
Copy link
Contributor

@joeljfischer The SDLLockScreenStatus enum is used extensively by the SDLLockScreenStatusManager and the SDLLockScreenManager to determine whether or not the lock screen should be presented. I think the SDLLockScreenStatus enum should be kept as it will be needed even when the SDLOnLockScreenStatus notification is removed.

@joeljfischer
Copy link
Contributor Author

@NicoleYarroch I think something like it will probably be kept (as a private enum, so it should still be deprecated), but it won’t be a fake SDL enum. It will probably be turned into a standard iOS enum instead. The lock screen status manager will eventually go away as well and / or moved into a sub-object of the LSM. All the logic should be captured by the LSM.

@NicoleYarroch
Copy link
Contributor

Fixed in PR #1608

@NicoleYarroch NicoleYarroch added this to Done in v6.6.0 via automation Mar 31, 2020
@joeljfischer joeljfischer mentioned this issue Apr 29, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway
Projects
No open projects
v6.6.0
  
Done
Development

No branches or pull requests

2 participants