New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synchronization around SDLResponseDispatcher #1552
Conversation
* Methods that alter the internal dictionaries and map tables are now synchronized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
* Use dispatch_barrier_async for writes and dispatch_sync for reads
I am getting anything random failing test cases (between 3 and 8 total) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about failing test cases
There were issues due to directly accessing properties for a value that was stored in |
Fixes #1515
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
No unit tests were added, they were run and pass.
Core Tests
Core version / branch / commit hash / module tested against: Sync 3.0 (19205_DEVTEST), Manticore v2.4.2 (SDL Core v6.0.1)
HMI name / version / branch / commit hash / module tested against: Sync 3.0 (19205_DEVTEST), Manticore v2.4.2 (Generic HMI v0.7.2.)
Summary
SDLResponseDispatcher
are now synchronized.Changelog
Bug Fixes
CLA