rpcResponseHandlerMap SIGABRT crash in the sdl library

[SunXiaoShan]

I got a crash in the sdl library.
The screen is from Firebase & Cocoapod.
I think the root cause is the variable rpcResponseHandlerMap is nil.
Could you check it again?

Reproduction Steps

1. Launch the app
2. Connect with the sdl device
3. Streaming the video

OS & Version Information

• iOS Version: 13.3.0
• Mobile: iPhone 11
• SDL iOS Version: 6.4.1

[NicoleYarroch]

@SunXiaoShan Is it possible to share the full crash report with us? I do not see any obvious bugs that would cause the crash when storing the request handler. I tried setting the rpcResponseHandlerMap dictionary to nil but that did not cause a crash. Having a nil correlationId did cause a crash but it is very different from the one you reported.

[SunXiaoShan]

@NicoleYarroch
So, I'm so sorry for reply late.
I dont get the feedback notification from github.
Maybe the message is ignored by mail system.
I will try to use 6.3.1 to test it again.
I never saw it before 6.4.1.

Keep monitor.
Thanks,
Phineas Huang

[NicoleYarroch]

@SunXiaoShan I suspect that the crash is happening because two writes to the rpcResponseHandlerMap are being attempted at the same time, however it is difficult to confirm this bug. I will keep an eye out and attach logs to this issue if I can reproduce.

[SunXiaoShan]

@NicoleYarroch
Got it, thanks.
I have no idea for it.
I think one of thing I can do is rollback to sdl 6.3.1 and confirm it again.

[SunXiaoShan]

@NicoleYarroch
I have tested it for a week.
It not happens on the sdl 6.3.1

[NicoleYarroch]

I just had this bug happen on SDL v6.4. I believe the issue is that multiple threads are accessing the rpcRequestDictionary at the same time . Since the dictionary is of type NSMutableDictionary, it is not thread safe which can cause EXC BAD ACCESS errors.

[NicoleYarroch]

Fixed in PR #1552.