Implement SDL-0243 Manager Update for DisplayCapability #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getter. Fixed bool vs. NSNumber condition. Fixed first time display backwards conversion. Fixed etst error in file manager toBeCloseTo was within 0.001 now is 0.01. Fixed a bug in menu manager test using wrong response notification name.
…issue_1386_manager_update_display_capability
…issue_1386_manager_update_display_capability # Conflicts: # SmartDeviceLink/SDLSystemCapability.h # SmartDeviceLink/SDLSystemCapability.m
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…ions. Renamed convert flag. Created window and display capability group. Changed media clock to empty array. Changed repeat test to unique data. Other minor suggestions applied.
…issue_1386_manager_update_display_capability # Conflicts resolved: # SmartDeviceLink/SDLSystemCapabilityManager.m # SmartDeviceLinkTests/DevAPISpecs/SDLFileManagerSpec.m # SmartDeviceLinkTests/DevAPISpecs/SDLMenuManagerSpec.m
…apabilityManagerSpec
…a local machine it always works
…in SDLSystemCapabilityManager.m
…https://github.com/yLeonid/sdl_ios into yLeonid-feature/issue_1386_manager_update_display_capability
* Fix example app deprecation warnings * Stylistic fixes * Text and Graphic / Soft Button managers now start when the screen manager starts, which allows them to try subscribing to DISPLAYS once the connection is established * Add additional pragma categories for system capability manager * Permit subscribing to DISPLAYS even if on systems < 5.1.0 because updates through SetDisplayLayout route through that subscription now
* Fix multiple text and graphic manager subscribes to display capability
joeljfischer
changed the title
5 tasks
|
|
justingluck93
suggested changes
Oct 3, 2019
justingluck93
approved these changes
Oct 4, 2019
joeljfischer
deleted the
feature/issue-1386-manager-update-display-capability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1386
Update from #1390 and #1419
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests were updated and run
Smoke tests were performed against:
SDL Core
SDL Core, v6.0.0-in-progress / develop / 7c442abce73c462e7724a64b3ce037bcb8e9093e
sdl_hmi, develop / 760d5e812f92c57f1676099029cbce72410b818b
generic_hmi, develop / 8c555b95cb8d580c3bf8e0ee6c3bf6f30179ec16
Sub-managers receive updated displays when the initial connection occurs.
Sub-managers receive updated displays when a new layout occurs.
TDK
Sync 3.4, 19248_DEVTEST
Sub-managers receive updated displays when the initial connection occurs.
Summary
This PR updates
SDLSystemCapabilityManagerwith the ability to subscribe to the new DISPLAYS type. Also updates other internal managers to use the new DISPLAY capabilities.Changelog
Enhancements
SDLSystemCapabilityManagerwith support for the new DISPLAYS type.Tasks Remaining:
CLA