Implement SDL-0243 Manager Update for Display Capability #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getter. Fixed bool vs. NSNumber condition. Fixed first time display backwards conversion. Fixed etst error in file manager toBeCloseTo was within 0.001 now is 0.01. Fixed a bug in menu manager test using wrong response notification name.
…issue_1386_manager_update_display_capability
…issue_1386_manager_update_display_capability # Conflicts: # SmartDeviceLink/SDLSystemCapability.h # SmartDeviceLink/SDLSystemCapability.m
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…ions. Renamed convert flag. Created window and display capability group. Changed media clock to empty array. Changed repeat test to unique data. Other minor suggestions applied.
…issue_1386_manager_update_display_capability # Conflicts resolved: # SmartDeviceLink/SDLSystemCapabilityManager.m # SmartDeviceLinkTests/DevAPISpecs/SDLFileManagerSpec.m # SmartDeviceLinkTests/DevAPISpecs/SDLMenuManagerSpec.m
…apabilityManagerSpec
…a local machine it always works
…in SDLSystemCapabilityManager.m
5 tasks
|
@yLeonid @kshala-ford can you please confirm if this is ready for Livio review? It appears there are still some tasks remaining. Note that this remaining task |
|
@theresalech I need to double check the PR #1350 and then I confirm if it is ready |
joeljfischer
changed the title
|
@theresalech This changeset is built upon the PR #1350 so it contains everything from that PR. |
|
@yLeonid I will review this PR today. Due to time constraints if there are any needed fixes I will open a new PR with those fixes and have another Livio developer review. Thank you for your work thus far. |
|
@joeljfischer Thank you Joel. |
7 tasks
|
Closed in favor of #1427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1386
Update from #1390
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Extend unit tests to confirm display capability/capabilities conversion is as expected.
Summary
This PR changes SystemCapabilityManager according to SDL-0243 to make new capabilities available and also convert DisplayCapability and DisplayCapabilities objects.
Changelog
Existing SystemCapabilityTypes are marked as deprecated hence will appear as deprecated if apps are using them.
Enhancements
Tasks Remaining:
Add DISPLAYS to manager
Add Conversion code
Do the unit (UI) tests
[Wait for Implement SDL-0216 Widget Support #1350 to be merged before requesting review]
CLA