Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align iOS and Android Replace SDLSyncMsgVersion with SDLMsgVersion #1354

Merged
merged 6 commits into from Jul 24, 2019
Merged

Align iOS and Android Replace SDLSyncMsgVersion with SDLMsgVersion #1354

merged 6 commits into from Jul 24, 2019

Commits on Jul 18, 2019

  1. WIP: removed unsued class from Globals, deprecating old class and rep… 

    …lacing it
    Justin Gluck committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    cc175c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. replaced SDLSyncMsgVersion with SDLMsgVersion, deprecated SDLSyncMsgV… 

    …ersion properties and created new SDLMsgVersion properties to replace it, deprecated inits and created new inits if SDLSyncMsgVersion was apart of the init. Added new and changed unit tests to go along with deprecation changes
    Justin Gluck committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    dda3b60 View commit details
    Browse the repository at this point in the history

  2. fixing small issues

    Justin Gluck committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    5b21ce6 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Apply suggestions from code review 

    PR updates

Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
    @justingluck93 @joeljfischer
    justingluck93 and joeljfischer committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    c910eff View commit details
    Browse the repository at this point in the history

  2. fixing PR issues

    Justin Gluck committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    4288fca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into bugfix/issue-1352-Align-SDLSyncVersion 

    # Conflicts:
#	SmartDeviceLink/SDLLifecycleManager.m
    Justin Gluck committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    65d75f0 View commit details
    Browse the repository at this point in the history