Align iOS and Android Replace SDLSyncMsgVersion with SDLMsgVersion #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 18, 2019 14:05
…ersion properties and created new SDLMsgVersion properties to replace it, deprecated inits and created new inits if SDLSyncMsgVersion was apart of the init. Added new and changed unit tests to go along with deprecation changes
joeljfischer
added
the
best practice
joeljfischer
suggested changes
Jul 23, 2019
SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLRegisterAppInterfaceResponseSpec.m
Outdated
Show resolved
Hide resolved
SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLAppServiceManifestSpec.m
Outdated
Show resolved
Hide resolved
SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLAppServiceManifestSpec.m
Outdated
Show resolved
Hide resolved
SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLAppServiceManifestSpec.m
Outdated
Show resolved
Hide resolved
PR updates Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
previously approved these changes
Jul 23, 2019
|
@justingluck93 Conflicts have appeared |
# Conflicts: # SmartDeviceLink/SDLLifecycleManager.m
joeljfischer
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Run app and check if responses and requests send proper data
Summary
Deprecated SDLSyncMsgVersion and replaced it with SDLMsgVersion.
CLA