Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SDL-0116 Open Menu RPC #1351

Merged
merged 12 commits into from Aug 1, 2019
Merged

Implement SDL-0116 Open Menu RPC #1351

merged 12 commits into from Aug 1, 2019

Commits on Jul 15, 2019

  1. WIP: setting up ShowAppMenu RPC

    Justin Gluck committed Jul 15, 2019
    Copy the full SHA
    861b3d4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. reverting file to before the commit

    Justin Gluck committed Jul 16, 2019
    Copy the full SHA
    2e5dfda View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. Adding file for response spec show app menu

    Justin Gluck committed Jul 17, 2019
    Copy the full SHA
    752f7a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Adding Function ID

    Justin Gluck committed Jul 24, 2019
    Copy the full SHA
    d815dab View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature/issue-806-OpenMenuRPC

    @justingluck93
    justingluck93 committed Jul 24, 2019
    Copy the full SHA
    8ab8e0b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. adding unit tests fixing PR issues, adding openMenu to screenManger a… 

    …nd menuManger
    Justin Gluck committed Jul 25, 2019
    Copy the full SHA
    d3c2d37 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. adding more unit tests fixing other tests, added logic to not send RP… 

    …C is cell in invalid
    Justin Gluck committed Jul 26, 2019
    Copy the full SHA
    fd726f7 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    PR fixing

Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
    @justingluck93 @joeljfischer
    justingluck93 and joeljfischer committed Jul 26, 2019
    Copy the full SHA
    9a60d2f View commit details
    Browse the repository at this point in the history

  3. adding documentation to init

    Justin Gluck committed Jul 26, 2019
    Copy the full SHA
    899c408 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. move tests from screen manager to the menu manager, added unit tests.… 

    … added documentation, fixing PR issues
    Justin Gluck committed Jul 31, 2019
    Copy the full SHA
    4b6a855 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Apply suggestions from code review 

    PR fixes

Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
    @justingluck93 @joeljfischer
    justingluck93 and joeljfischer committed Aug 1, 2019
    Copy the full SHA
    0e59f16 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
    @justingluck93 @joeljfischer
    justingluck93 and joeljfischer committed Aug 1, 2019
    Copy the full SHA
    12d5bd6 View commit details
    Browse the repository at this point in the history