Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SDL-0116 Open Menu RPC #1351

Merged
merged 12 commits into from Aug 1, 2019
Merged

Conversation

justingluck93
Copy link
Contributor

@justingluck93 justingluck93 commented Jul 17, 2019

Fixes #806

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Send a RPC request to HMI to open the menu

SDLShowAppMenu *showMenu = [[SDLShowAppMenu alloc] init];
[self.sdlManager sendRequest:showMenu withResponseHandler:^(__kindof SDLRPCRequest * _Nullable request, __kindof SDLRPCResponse * _Nullable response, NSError * _Nullable error) {
       if (error != nil) { return; }
       // Use Response if needed
    }];
SDLShowAppMenu *showMenu = [[SDLShowAppMenu alloc] init];
showMenu.menuID = //MenuID With SubCells
[self.sdlManager sendRequest:showMenu withResponseHandler:^(__kindof SDLRPCRequest * _Nullable request, __kindof SDLRPCResponse * _Nullable response, NSError * _Nullable error) {
       if (error != nil) { return; }
       // Use Response if needed
    }];

CLA

@justingluck93 justingluck93 self-assigned this Jul 17, 2019
@justingluck93 justingluck93 changed the title Open Menu RPC Implement SDL-0116 Open Menu RPC Jul 18, 2019
@joeljfischer joeljfischer added enhancement proposal Accepted SDL Evolution Proposal labels Jul 22, 2019
@joeljfischer joeljfischer added this to In progress in v6.4 via automation Jul 22, 2019
@joeljfischer joeljfischer added this to the 6.4.0 milestone Jul 22, 2019
v6.4 automation moved this from In progress to Review in progress Jul 24, 2019
SmartDeviceLink/SDLScreenManager.h Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLShowAppMenu.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.h Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLScreenManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
PR fixes

Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the last of the formatting errors

SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
SmartDeviceLink/SDLMenuManager.m Outdated Show resolved Hide resolved
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
v6.4 automation moved this from Review in progress to Reviewer approved Aug 1, 2019
@joeljfischer joeljfischer merged commit f43c7f4 into develop Aug 1, 2019
v6.4 automation moved this from Reviewer approved to Done Aug 1, 2019
@joeljfischer joeljfischer deleted the feature/issue-806-OpenMenuRPC branch August 1, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Accepted SDL Evolution Proposal
Projects
No open projects
v6.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants