New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SDL-0187 Restructure iOS Threading and Queueing #1348
Implement SDL-0187 Restructure iOS Threading and Queueing #1348
Conversation
# Conflicts: # SmartDeviceLink/SDLStreamDelegate.m
# Conflicts: # SmartDeviceLink/SDLAudioStreamManager.m
* See todo for current location
# Conflicts: # SmartDeviceLink/SDLMenuManager.m
* Add description to SDLFile * Fix FileManager cancelling all files
* Fix upload file operation spec
# Conflicts: # SmartDeviceLink/SDLLifecycleManager.m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
SmartDeviceLink-iOS.xcodeproj/xcshareddata/xcschemes/SmartDeviceLink.xcscheme
Outdated
Show resolved
Hide resolved
SYNC 3 doesn't seem to be handling multiple |
After investigation, it seems that this is primarily a Ford issue with their HMI's handling of I was unable to determine that this happens at a more frequent rate than the previous 6.3.1 release, and testing this branch with a full-featured internal media app showed qualitative improvement in speed when connected to Ford's head unit. Additional improvements will likely only be possible by batching together soft button and graphic Show updates. This isn't currently possible with the structure of the This would be quite a large bit of work, however, and is out of the scope of this proposal implementation, so I will leave that to future work. |
Fixes #1028
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit tests updated and smoke tests added
Summary
This PR restructures the threading in the library to use an "execution context" structure.
Changelog
Enhancements
Tasks Remaining:
CLA