Implement SDL-0187 Restructure iOS Threading / Queueing #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # SmartDeviceLink/SDLStreamDelegate.m
joeljfischer
changed the title
# Conflicts: # SmartDeviceLink/SDLAudioStreamManager.m
joeljfischer
changed the title
joeljfischer
changed the title
NicoleYarroch
suggested changes
Jun 10, 2019
| @@ -60,6 +60,11 @@ | |||
| </BuildableReference> | |||
| </MacroExpansion> | |||
| <AdditionalOptions> | |||
| <AdditionalOption | |||
| key = "NSZombieEnabled" | |||
| value = "YES" | |||
There was a problem hiding this comment.
This is for debugging, right?
There was a problem hiding this comment.
Yes, but since it's on the test scheme, it can just stay enabled.
| @@ -92,7 +92,7 @@ - (void)sdl_sendFile:(SDLFile *)file mtuSize:(NSUInteger)mtuSize withCompletion: | |||
|
|
|||
| // Wait for all packets be sent before returning whether or not the upload was a success | |||
| __weak typeof(self) weakself = self; | |||
| dispatch_group_notify(putFileGroup, dispatch_get_main_queue(), ^{ | |||
| dispatch_group_notify(putFileGroup, [SDLGlobals sharedGlobals].sdlProcessingQueue, ^{ | |||
There was a problem hiding this comment.
Isn't this a breaking change, since devs will expect to get the response on the main thread?
* See todo for current location
joeljfischer
changed the title
|
Closed due to wrong branch name. New version is at #1348. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit and smoke tests
Summary
This PR restructures the threading in the library to use an "execution context" structure.
Changelog
Enhancements
Tasks Remaining:
serialTransportqueue and use the processing queueconcurrentProcessingqueueCLA