Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background task for establishing transport session now stopped when lifecycle manager reaches ready state #1333

Merged
merged 1 commit into from Jul 18, 2019
Merged

Background task for establishing transport session now stopped when lifecycle manager reaches ready state #1333

merged 1 commit into from Jul 18, 2019

Conversation

NicoleYarroch
Copy link
Contributor

Fixes #1326

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Smoke tests performed.

  • Connected 10 apps (all backgrounded) to a head unit via iAP and waited 10 minutes before launching and interacting with the app.
  • Waited 10 minutes before pulling and reconnecting the phone using a USB cord.

Summary

  • Instead of stopping any ongoing background task when the transport is established, the background task is now stopped after all setup for the library managers has completed and the lifecycle manager has entered the ready state. This ensures that the RegisterAppInterface request is sent to Core (theoretically once the session has been established successfully, the SDL app should have unlimited background time, however there have been issues with the app being suspended before the RAI request is sent to Core).

Changelog

Breaking Changes
  • none
Enhancements
  • n/a
Bug Fixes
  • Fixed destroyed background task preventing the RAI request being sent to Core

CLA

@NicoleYarroch NicoleYarroch added the bug A defect in the library label Jul 9, 2019
@NicoleYarroch NicoleYarroch self-assigned this Jul 9, 2019
@NicoleYarroch NicoleYarroch added this to In progress in v6.3.1 via automation Jul 9, 2019
@NicoleYarroch NicoleYarroch mentioned this pull request Jul 9, 2019
Closed
v6.3.1 automation moved this from In progress to Reviewer approved Jul 18, 2019
@joeljfischer joeljfischer merged commit 948a1f4 into develop Jul 18, 2019
v6.3.1 automation moved this from Reviewer approved to Done Jul 18, 2019
@joeljfischer joeljfischer deleted the bugfix/issue_1326_background_task_suspended_before_RAI_sent branch July 18, 2019 14:18
@joeljfischer joeljfischer mentioned this pull request Jul 18, 2019
Closed
@joeljfischer joeljfischer restored the bugfix/issue_1326_background_task_suspended_before_RAI_sent branch July 18, 2019 14:37
@joeljfischer joeljfischer deleted the bugfix/issue_1326_background_task_suspended_before_RAI_sent branch July 18, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeljfischer joeljfischer joeljfischer approved these changes

Assignees

@NicoleYarroch NicoleYarroch

Labels
bug A defect in the library
Projects
No open projects
v6.3.1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NicoleYarroch @joeljfischer