Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed session creation failing due to no background task #1317

Merged
merged 16 commits into from Jun 26, 2019
Merged

Fixed session creation failing due to no background task #1317

merged 16 commits into from Jun 26, 2019

Commits on Jun 24, 2019

  1. Removed registration for EAAcessory notifications 

    Removed unecessary registration for EAAcessory notifications
    @NicoleYarroch
    NicoleYarroch committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    960105d View commit details
    Browse the repository at this point in the history

  2. background tasks now use weakself

    @NicoleYarroch
    NicoleYarroch committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    b555ed8 View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary import

    @NicoleYarroch
    NicoleYarroch committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    0e14619 View commit details
    Browse the repository at this point in the history

  4. Transport dealloc does not end the background task 

    Background task should not be destroyed when transport is destroyed
    @NicoleYarroch
    NicoleYarroch committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    31bf850 View commit details
    Browse the repository at this point in the history

  5. Background task now started in init of IAPTransport 

    Background task now started in init of SDLIAPTransport
    @NicoleYarroch
    NicoleYarroch committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    55d9180 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Moved the background task to the LifecycleManager 

    Moved the background task from the iAPTransport class to the LifecycleManager class
    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    2d1a812 View commit details
    Browse the repository at this point in the history

  2. Background task killed on dealloc 

    Background task destroyed when the lifecycle manager is dealloced
    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    2442637 View commit details
    Browse the repository at this point in the history

  3. Added more detail to SDL logs

    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    bbe955b View commit details
    Browse the repository at this point in the history

  4. Update SmartDeviceLink/SDLLifecycleManager.m 

    Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
    @NicoleYarroch @joeljfischer
    NicoleYarroch and joeljfischer committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    0c1f817 View commit details
    Browse the repository at this point in the history

  5. Moved background task logic to own class

    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    2ca35f4 View commit details
    Browse the repository at this point in the history

  6. Removed dealloc from SDLManager

    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    db9ade2 View commit details
    Browse the repository at this point in the history

  7. Added class

    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    75d3b6e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'bugfix/issue_1316_background_task_session_creation_fail… 

    …s' of https://github.com/smartdevicelink/sdl_ios into bugfix/issue_1316_background_task_session_creation_fails

# Conflicts:
#	SmartDeviceLink/SDLLifecycleManager.m
    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    14e1f5e View commit details
    Browse the repository at this point in the history

  9. renamed var

    @NicoleYarroch
    NicoleYarroch committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    c0b0457 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Moved documentation to Background Task header file

    @NicoleYarroch
    NicoleYarroch committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    8a3f94e View commit details
    Browse the repository at this point in the history

  2. Moved dealloc to BackgroundTaskManager 

    * cleaned up some documentation
    @NicoleYarroch
    NicoleYarroch committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    b8098be View commit details
    Browse the repository at this point in the history