Fixed session creation failing due to no background task #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unecessary registration for EAAcessory notifications
Background task should not be destroyed when transport is destroyed
Background task now started in init of SDLIAPTransport
joeljfischer
suggested changes
Jun 24, 2019
Moved the background task from the iAPTransport class to the LifecycleManager class
Background task destroyed when the lifecycle manager is dealloced
joeljfischer
suggested changes
Jun 25, 2019
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…s' of https://github.com/smartdevicelink/sdl_ios into bugfix/issue_1316_background_task_session_creation_fails # Conflicts: # SmartDeviceLink/SDLLifecycleManager.m
* cleaned up some documentation
joeljfischer
approved these changes
Jun 26, 2019
joeljfischer
deleted the
bugfix/issue_1316_background_task_session_creation_fails
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
SDLIAPTransportis created, a background task is now started.EAAccessoryconnections in theSDLProxyclass.Changelog
Bug Fixes
CLA