Fix SoftButtonManager Race Conditions #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeljfischer
changed the title
* Working on test cases
joeljfischer
changed the title
NicoleYarroch
suggested changes
May 17, 2019
NicoleYarroch
suggested changes
May 20, 2019
NicoleYarroch
approved these changes
May 23, 2019
This was referenced May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1177, #1234
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Smoke tests + unit tests
Summary
This PR fixes several longstanding state issues in the
SoftButtonManagerby simplifying the logic usingNSOperation. One such issue is when transitioning states really close together, only one state would transition due to race conditions.Changelog
Bug Fixes
Tasks Remaining:
CLA