Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioning multiple soft buttons to the next state in the Soft Button manager fails #1234

Closed
NicoleYarroch opened this issue Apr 11, 2019 · 1 comment
Labels
bug A defect in the library
Projects

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

  1. If two soft buttons transition to the new state at the same time, the second button state will not be sent in the updateWithCompletionHandler: method because the isDirty param is set to NO by the first button transition.
Reproduction Steps
  1. Use the ScreenManager to set two buttons, buttonA and buttonB, with multiple states. When buttonA is tapped, transition buttonA to the next state and buttonB to the next state.
  2. Connect the app to Core
  3. Tap on buttonA on the SDL app
Expected Behavior

Both button states transition successfully to the next state.

Observed Behavior

Only buttonA transitions to the next state. ButtonB stays in its current state.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 6.1
  • Testing Against: Manticore
@NicoleYarroch NicoleYarroch added the bug A defect in the library label Apr 11, 2019
@NicoleYarroch NicoleYarroch changed the title Race condition in Soft Button manager Transitioning multiple soft buttons to the next state in the Soft Button manager fails Apr 11, 2019
@theresalech
Copy link
Contributor

Fixed via #1251

@theresalech theresalech added this to To do in v6.3 via automation May 23, 2019
@theresalech theresalech moved this from To do to Done in v6.3 May 23, 2019
@joeljfischer joeljfischer mentioned this issue Jun 24, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
No open projects
v6.3
  
Done
Development

No branches or pull requests

2 participants