New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.3.0 Release #1301
Merged
Merged
v6.3.0 Release #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Separated out control session logic in SDLIAPTransport into the SDLIAPControlSession class * Added test cases for the SDLIAPControlSession class
Fixed switching transports between USB and BT not working if a control session was opened before the data session.
* Working on test cases
…od to add and remove cells , we must remove all cells and re add all cells after artwork uploads
…tocol to ensure to cleanup correctly
…rotocol-to-strong Fix/make reference to primaryProtocol to strong
…s. modified some tests to match code changes
Removed unecessary registration for EAAcessory notifications
Background task should not be destroyed when transport is destroyed
Background task now started in init of SDLIAPTransport
Moved the background task from the iAPTransport class to the LifecycleManager class
Background task destroyed when the lifecycle manager is dealloced
…Icons-dont-show Cell Icons do not show up on first menu set
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…s' of https://github.com/smartdevicelink/sdl_ios into bugfix/issue_1316_background_task_session_creation_fails # Conflicts: # SmartDeviceLink/SDLLifecycleManager.m
* cleaned up some documentation
…round_task_session_creation_fails Fixed session creation failing due to no background task
…r-session-creation-failure add nil check of eaSession at SDLIAPDataSession#startSession
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests and full smoke tests
Summary
SDL iOS 6.3.0 brings enhancements and bug fixes including dynamic menu updates,
SDLSystemCapability
subscriptions, and a re-written IAP transport.It supports SDL RPC Spec 5.1.0 and SDLProtocol Spec 5.2.0.
Changelog
Enhancements
SDLManager
for ease of use ([SDL 0226] Add iOS SDLManager RPC Subscriptions #1257).SDLAudioStreamManager
([SDL 0232] Add Pushing Buffer Support to AudioStreamManager #1275).Bug Fixes
SDLManager
delegate methods not getting called in certain circumstances (SDLManagerDelegate methods not getting called #1243, 'SDLManagerDelegate`s are not called if the data session is established successfully but the lifecycle manager does not transition to state ready #1264).SDLManager.stop
crashes in certain circumstances (Example apps crash if thestop
method is called when the lifecycle manager errors #1268).SDLAudioStreamManager
API (TheSDLAudioStreamManager
public propertyqueue
is inaccessible #1283).SDLChoiceSet``vrHelpItems
outside of the initializer not properly setting their position indexes (Setting SDLChoiceSet vrHelpItems outside of initializer doesn't set the position to a 1 based index #1291).Example Apps
resetConnection
causing a crash (Example appsresetConnection
crashes app #1237).Dependencies
CLA