Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCIP-2208 Add MetricsRegisterer to CCIP OracleArgs #771

Merged
merged 5 commits into from Apr 30, 2024

Conversation

george-dorin
Copy link
Collaborator

The new version of libocr has a MetricsRegisterer that enables some P2P metrics, adding the MetricsRegisterer to the OracleArgs of CCIP

Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset.

@george-dorin george-dorin marked this pull request as ready for review April 29, 2024 11:17
@george-dorin george-dorin requested a review from a team as a code owner April 29, 2024 11:17
@mateusz-sekara
Copy link
Contributor

mateusz-sekara commented Apr 29, 2024

@george-dorin does it solve spike of the nil registerer implementation during boot?
example

github.com/smartcontractkit/libocr/internal/metricshelper.Register0rLogError
  /go/pkg/mod/github.com/smartcontractkit/libocr@v0.0.0-20240229181116-bfb2432a/a66/internal/metricshelper/registerer.go:59
github.com/smartcontractkit/libocr/offchainreporting2plus/internal/oer2/protoco1.newPacemakerMetrics
  /go/pkg/mod/github.com/smartcontractkit/libocr@v0.0.0-20240229181116-bfb2432a7a66/offchainreporting2plus/internal/ocr2/protocol/metrics.go: 27
github.com/smartcontractkit/libocr/offchainreporting2plus/internal/oer2/protoco1.makePacemakerState
  /go/pkg/mod/github.com/smartcontractkit/libocr@v0.0.0-20240229181116-bfb2432a/a66/offchainreporting2plus/internal/ocr2/protocol/pacemaker.go: 90
github.com/smartcontractkit/libocr/offchainreporting2plus/internal/oer2/protoco1. RunPacemaker
  /go/pkg/mod/github.com/smartcontractkit/libocr@v0.0.0-20240229181116-bfb2432a/a66/offchainreporting2plus/internal/ocr2/protocol/pacemaker.go: 49
github.com/smartcontractkit/libocr/offchainreporting2plus/internal/ocr2/protoco1. (*oracleState).run.func1
  /go/pkg/mod/github.com/smartcontractkit/libocr@v0.0.0-20240229181116-bfb2432a/a66/offchainreporting2plus/internal/ocr2/protocol/oracle.go: 150
github.com/smartcontractkit/libocr/subprocesses.*Subprocesses.Go.func1/go/pkg/mod/github.com/smartcontractkit/libocr@v0.0.0-20240229181116-

@mateusz-sekara mateusz-sekara changed the title Add MetricsRegisterer to CCIP OracleArgs CCIP-2208 Add MetricsRegisterer to CCIP OracleArgs Apr 29, 2024
@george-dorin
Copy link
Collaborator Author

@george-dorin does it solve spike of the nil registerer implementation during boot?
example
@mateusz-sekara Yes, it solves that issue

@george-dorin george-dorin enabled auto-merge (squash) April 29, 2024 12:56
@george-dorin george-dorin merged commit dc288e9 into ccip-develop Apr 30, 2024
85 checks passed
@george-dorin george-dorin deleted the add-metrics-registerer-to-ccip branch April 30, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants