Skip to content

Commit

Permalink
CCIP-2208 Add MetricsRegisterer to CCIP OracleArgs (#771)
Browse files Browse the repository at this point in the history
The new version of `libocr` has a MetricsRegisterer that enables some
P2P metrics, adding the MetricsRegisterer to the OracleArgs of CCIP

---------

Co-authored-by: Mateusz Sekara <mateusz.sekara@gmail.com>
  • Loading branch information
george-dorin and mateusz-sekara committed Apr 30, 2024
1 parent ed0a8ee commit dc288e9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/twelve-grapes-hammer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ccip": patch
---

#internal Add metrics registerer to CCIP OracleArgs
3 changes: 3 additions & 0 deletions core/services/ocr2/delegate.go
Original file line number Diff line number Diff line change
Expand Up @@ -1754,6 +1754,7 @@ func (d *Delegate) newServicesCCIPCommit(ctx context.Context, lggr logger.Sugare
OffchainConfigDigester: ccipProvider.OffchainConfigDigester(),
OffchainKeyring: kb,
OnchainKeyring: kb,
MetricsRegisterer: prometheus.WrapRegistererWith(map[string]string{"job_name": jb.Name.ValueOrZero()}, prometheus.DefaultRegisterer),
}
logError := func(msg string) {
lggr.ErrorIf(d.jobORM.RecordError(jb.ID, msg), "unable to record error")
Expand Down Expand Up @@ -1807,6 +1808,7 @@ func (d *Delegate) newServicesCCIPExecution(ctx context.Context, lggr logger.Sug
OffchainConfigDigester: ccipProvider.OffchainConfigDigester(),
OffchainKeyring: kb,
OnchainKeyring: kb,
MetricsRegisterer: prometheus.WrapRegistererWith(map[string]string{"job_name": jb.Name.ValueOrZero()}, prometheus.DefaultRegisterer),
}
logError := func(msg string) {
lggr.ErrorIf(d.jobORM.RecordError(jb.ID, msg), "unable to record error")
Expand Down Expand Up @@ -1875,6 +1877,7 @@ func (d *Delegate) newServicesRebalancer(ctx context.Context, lggr logger.Sugare
Logger: commonlogger.NewOCRWrapper(lggr.Named("RebalancerOracle"), d.cfg.OCR2().TraceLogging(), func(msg string) {
lggr.ErrorIf(d.jobORM.RecordError(jb.ID, msg), "unable to record error")
}),
MetricsRegisterer: prometheus.WrapRegistererWith(map[string]string{"job_name": jb.Name.ValueOrZero()}, prometheus.DefaultRegisterer),
}
oracle, err := libocr2.NewOracle(oracleArgsNoPlugin)
if err != nil {
Expand Down

0 comments on commit dc288e9

Please sign in to comment.