Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Updated hard-coded core version in another file #2207

Merged
merged 3 commits into from Mar 5, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Mar 5, 2024

Issue and/or context: Found on drive-by while debugging TileDB-Inc/tiledbsoma-feedstock#95

Changes: Now that we have one more hard-coded path (#1937), have the updater not fail to update it

Notes for Reviewer:

@johnkerl johnkerl requested a review from jp-dark March 5, 2024 19:32
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #2207 (ebc45ce) into main (05cf351) will decrease coverage by 6.93%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2207      +/-   ##
==========================================
- Coverage   77.68%   70.76%   -6.93%     
==========================================
  Files         137      103      -34     
  Lines       10679     6871    -3808     
  Branches      214      214              
==========================================
- Hits         8296     4862    -3434     
+ Misses       2297     1923     -374     
  Partials       86       86              
Flag Coverage Δ
libtiledbsoma 63.98% <ø> (ø)
python ?
r 74.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api ∅ <ø> (∅)
libtiledbsoma 48.69% <ø> (ø)

@johnkerl johnkerl merged commit 29c55e1 into main Mar 5, 2024
23 checks passed
@johnkerl johnkerl deleted the kerl/update-version-for-so-copying-ci branch March 5, 2024 20:34
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
* [ci] Updated hard-coded core version in another file

* Run the script

* comment
github-actions bot pushed a commit that referenced this pull request Mar 5, 2024
* [ci] Updated hard-coded core version in another file

* Run the script

* comment
johnkerl added a commit that referenced this pull request Mar 5, 2024
* [ci] Updated hard-coded core version in another file

* Run the script

* comment

Co-authored-by: John Kerl <kerl.john.r@gmail.com>
johnkerl added a commit that referenced this pull request Mar 5, 2024
…r file (#2212)

* [ci] Updated hard-coded core version in another file (#2207)

* [ci] Updated hard-coded core version in another file

* Run the script

* comment

* Run `scripts/update-tiledb-version.py`

---------

Co-authored-by: John Kerl <kerl.john.r@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants