[Backport release-1.7] [ci] Updated hard-coded core version in another file #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* [ci] Updated hard-coded core version in another file * Run the script * comment
johnkerl
approved these changes
Mar 5, 2024
jdblischak
reviewed
Mar 5, 2024
| @@ -103,6 +103,10 @@ def main(args): | |||
| filepath = f"{os.path.dirname(__file__)}/../apis/r/tools/get_tarball.R" | |||
| update_version(filepath, new_version, new_hash, update_sha=False) | |||
|
|
|||
| # update CI version | |||
| filepath = f"{os.path.dirname(__file__)}/../.github/workflows/python-so-copying.yml" | |||
There was a problem hiding this comment.
But this file won't exist after #2211 is merged, right? I'm not following the logic of backporting this commit. If it is simply a bot that backports every commit that lands on main, I think this can be closed
There was a problem hiding this comment.
@jdblischak please see #2210
Yes, I do have multiple PRs in flight in multiple branches -- sequenced as my understanding has unfolded/developed throughout this afternoon
I'll resolve this bookkeeping issue -- freeing you up to work on other things -- I'll clean up from here
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.7 #2212 +/- ##
===============================================
- Coverage 77.68% 74.69% -2.99%
===============================================
Files 137 52 -85
Lines 10679 4347 -6332
Branches 214 0 -214
===============================================
- Hits 8296 3247 -5049
+ Misses 2297 1100 -1197
+ Partials 86 0 -86
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 29c55e1 from #2207