Trigger preproduction sync only after merge to main #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydentherapper
commented
Mar 13, 2024
|
|
||
| name: Sync Published Ceremony Branch to Main and Preprod | ||
|
|
||
| # Declare default permissions as none. | ||
| permissions: {} | ||
|
|
||
| on: | ||
| schedule: |
There was a problem hiding this comment.
@kommendorkapten any reason you think this is needed? i don't see why we need to continually try to sync
There was a problem hiding this comment.
I think the idea is to open a PR automatically when the ceremony branch is ready, but I think that's quite unnecessary, it's trivial to open that PR manually so I'm in favour of dropping this.
There was a problem hiding this comment.
I think this is already covered under the push condition, once the ceremony branch is created and pushed to.
haydentherapper
force-pushed
the
fix-ceremony-sync
branch
from
527e053
to
18fce44
Compare
jku
previously approved these changes
Mar 14, 2024
cpanato
previously approved these changes
Mar 14, 2024
In sigstore#916, we restructured the sync scripts. As part of this, the sync to preprod after a ceremony completed would occur from the ceremony branch. We only allow workload impersonation (which is needed to push to GCS and update the CDN cache) from main, so this breaks. To fix this, we simply split the workflow into two: The first triggers on a push to ceremony and creates a PR to merge to main. After merging from main and updating the root, we sync all contents from the repository directory. I also removed the cron job because I don't think it's needed. Also updated documentation for post-merge steps. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
dismissed stale reviews from kommendorkapten, cpanato, and jku
via
b6d2ef5
haydentherapper
force-pushed
the
fix-ceremony-sync
branch
from
18fce44
to
b6d2ef5
Compare
|
Had to rebase, ready to merge |
cpanato
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #916, we restructured the sync scripts. As part of this, the sync to preprod after a ceremony completed would occur from the ceremony branch. We only allow workload impersonation (which is needed to push to GCS and update the CDN cache) from main, so this breaks.
To fix this, we simply split the workflow into two: The first triggers on a push to ceremony and creates a PR to merge to main. After merging from main and updating the root, we sync all contents from the repository directory.
I also removed the cron job because I don't think it's needed. Also updated documentation for post-merge steps.
Fixes #1165
Summary
Release Note
Documentation