Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Workflow failure 'Sync Published Ceremony Branch to Main and Preprod' #1165

Closed
github-actions bot opened this issue Mar 13, 2024 · 4 comments · Fixed by #1170
Closed

[bug]: Workflow failure 'Sync Published Ceremony Branch to Main and Preprod' #1165

github-actions bot opened this issue Mar 13, 2024 · 4 comments · Fixed by #1170
Labels
bug Something isn't working

Comments

@github-actions
Copy link
Contributor

Workflow run failed for 'Sync Published Ceremony Branch to Main and Preprod'.

Run: https://github.com/sigstore/root-signing/actions/runs/8261650990
Workflow: https://github.com/sigstore/root-signing/blob/refs/heads/ceremony/2024-03-12/.github/workflows/sync-ceremony-to-main.yml
Workflow runs: https://github.com/sigstore/root-signing/actions/workflows/sync-ceremony-to-main.yml
Trigger: push on refs/heads/ceremony/2024-03-12
Date: 2024-03-13T08:32:12Z

@github-actions github-actions bot added the bug Something isn't working label Mar 13, 2024
@jku
Copy link
Member

jku commented Mar 13, 2024

I think this is an expected failure in the sense that the workflow run happened in the ceremony branch where it does not have permissions on GCP (see #984).

I don't know how "preprod" is meant to be deployed though: @kommendorkapten I assume you handle this one (once the client test issues are sorted)?

@kommendorkapten
Copy link
Member

@jku yes, I take a look once we are ready. We did change how this worked a while ago (but after the last signing ceremony I believe) so there may be some issues with it.

@haydentherapper
Copy link
Contributor

Confirming the issue is that https://github.com/sigstore/root-signing/blob/refs/heads/ceremony/2024-03-12/.github/workflows/sync-ceremony-to-main.yml is running from a branch and trying to sync to the preprod bucket, when we don't allow workload impersonation from non-main branches. Thinking out loud, rather than syncing from a ceremony branch, when we push an update to the root metadata, we should sync the entire repository/* folder to preprod.

@haydentherapper
Copy link
Contributor

#1170 should fix this. This splits the workflow into two:

  • First workflow runs after we generate the ceremony branch, which occurs as a byproduct of signing the timestamp/snapshot. This workflow will simply generate the PR that pushes the ceremony branch to main
  • Second workflow runs after a push to main that updates the root.json file. Technically this doesn't cover only updating the target file, but a) we've never done that, b) if we're getting all keyholders together, we'd update the root too, c) this will all get simplified with tuf-on-ci. This workflow pushes the repository/repository/** contents to main.

Note the two other workflows, which are unchanged:

  • "sync preprod to prod" needs to be manually run after we've verified against preprod
  • "sync main to preprod and prod" which runs automatically when we publish an update with changes to only the timestamp and/or snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants