move collectd-apache tests to use golden files. #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughesjj
approved these changes
Mar 26, 2024
| @@ -8,5 +8,4 @@ fi | |||
|
|
|||
| "$KAFKA_BIN"/kafka-console-consumer.sh \ | |||
| --bootstrap-server "$KAFKA_BROKER" \ | |||
| --topic sfx-employee \ | |||
| --max-messages $((10 + RANDOM % 100)) | |||
There was a problem hiding this comment.
seems like important tribal knowledge: any reason why we're removing the --max-messages flag? A short description would suffice, not worried about shipping this modified test as proposed.
There was a problem hiding this comment.
I think this relate to @atoulme 's slack message gist.
Kafka tests would not detect some of kafka's metrics based on the activity of kafka itself. There were multiple things to it:
The message sender had a random number of messages to send. It would send 10 + at most 100.
The broker would only emit metrics related to its roll stats if it rolled a segment.
In other word this will ensure Kafka's behavior more deterministic.
samiura
approved these changes
Mar 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.