move collectd-apache tests to use golden files. (#4534)

* fix kafka docker image

* move apache tests to golden files

docker/kafka/scripts/run-broker.sh

@@ -6,4 +6,5 @@ if [[ -z "$KAFKA_ZOOKEEPER_CONNECT" ]]; then
     exit 1
 fi
 "$KAFKA_BIN"/kafka-server-start.sh "${KAFKA_BIN}/../config/server.properties" \
-    --override zookeeper.connect="$KAFKA_ZOOKEEPER_CONNECT"
+    --override zookeeper.connect="$KAFKA_ZOOKEEPER_CONNECT" \
+    --override log.segment.bytes="100"

docker/kafka/scripts/run-consumer.sh

@@ -8,5 +8,4 @@ fi
 
 "$KAFKA_BIN"/kafka-console-consumer.sh \
    --bootstrap-server "$KAFKA_BROKER" \
-   --topic sfx-employee \
-   --max-messages $((10 + RANDOM % 100))
+   --topic sfx-employee

tests/receivers/smartagent/collectd-apache/collectd_apache_test.go

@@ -17,19 +17,80 @@
 package tests
 
 import (
+	"context"
+	"fmt"
+	"path/filepath"
+	"runtime"
 	"testing"
+	"time"
+
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/golden"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatatest/pmetrictest"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"go.opentelemetry.io/collector/component/componenttest"
+	"go.opentelemetry.io/collector/consumer/consumertest"
+	"go.opentelemetry.io/collector/receiver/otlpreceiver"
+	"go.opentelemetry.io/collector/receiver/receivertest"
+	"go.uber.org/zap"
 
 	"github.com/signalfx/splunk-otel-collector/tests/testutils"
 )
 
 func TestCollectdApacheReceiverProvidesAllMetrics(t *testing.T) {
-	testutils.AssertAllMetricsReceived(
-		t, "all.yaml", "all_metrics_config.yaml", nil, nil,
-	)
+	checkGoldenFile(t, "all_metrics_config.yaml", "expected_all.yaml",
+		pmetrictest.IgnoreMetricAttributeValue("host"),
+		pmetrictest.IgnoreMetricsOrder(),
+		pmetrictest.IgnoreMetricValues(),
+		pmetrictest.IgnoreTimestamp())
 }
 
 func TestCollectdApacheReceiverProvidesDefaultMetrics(t *testing.T) {
-	testutils.AssertAllMetricsReceived(
-		t, "default.yaml", "default_metrics_config.yaml", nil, nil,
-	)
+	checkGoldenFile(t, "default_metrics_config.yaml", "expected_default.yaml",
+		pmetrictest.IgnoreMetricAttributeValue("host"),
+		pmetrictest.IgnoreMetricsOrder(),
+		pmetrictest.IgnoreMetricValues(),
+		pmetrictest.IgnoreTimestamp())
+}
+
+func checkGoldenFile(t *testing.T, configFile string, expectedFilePath string, options ...pmetrictest.CompareMetricsOption) {
+	f := otlpreceiver.NewFactory()
+	port := testutils.GetAvailablePort(t)
+	c := f.CreateDefaultConfig().(*otlpreceiver.Config)
+	c.GRPC.NetAddr.Endpoint = fmt.Sprintf("localhost:%d", port)
+	sink := &consumertest.MetricsSink{}
+	receiver, err := f.CreateMetricsReceiver(context.Background(), receivertest.NewNopCreateSettings(), c, sink)
+	require.NoError(t, err)
+	require.NoError(t, receiver.Start(context.Background(), componenttest.NewNopHost()))
+	t.Cleanup(func() {
+		require.NoError(t, receiver.Shutdown(context.Background()))
+	})
+	logger, _ := zap.NewDevelopment()
+
+	dockerHost := "0.0.0.0"
+	if runtime.GOOS == "darwin" {
+		dockerHost = "host.docker.internal"
+	}
+	p, err := testutils.NewCollectorContainer().
+		WithConfigPath(filepath.Join("testdata", configFile)).
+		WithLogger(logger).
+		WithEnv(map[string]string{"OTLP_ENDPOINT": fmt.Sprintf("%s:%d", dockerHost, port)}).
+		Build()
+	require.NoError(t, err)
+	require.NoError(t, p.Start())
+	t.Cleanup(func() {
+		require.NoError(t, p.Shutdown())
+	})
+
+	expected, err := golden.ReadMetrics(filepath.Join("testdata", expectedFilePath))
+	require.NoError(t, err)
+
+	assert.EventuallyWithT(t, func(tt *assert.CollectT) {
+		if len(sink.AllMetrics()) == 0 {
+			assert.Fail(tt, "No metrics collected")
+			return
+		}
+		err := pmetrictest.CompareMetrics(expected, sink.AllMetrics()[len(sink.AllMetrics())-1], options...)
+		assert.NoError(tt, err)
+	}, 30*time.Second, 1*time.Second)
 }

tests/receivers/smartagent/collectd-apache/testdata/all_metrics_config.yaml

@@ -6,6 +6,9 @@ receivers:
     extraMetrics: ["*"]
     intervalSeconds: 1
 
+processors:
+  batch:
+
 exporters:
   otlp:
     endpoint: "${OTLP_ENDPOINT}"
@@ -17,4 +20,5 @@ service:
     metrics:
       receivers:
         - smartagent/collectd_apache
+      processors: [batch]
       exporters: [otlp]

tests/receivers/smartagent/collectd-apache/testdata/default_metrics_config.yaml

@@ -4,6 +4,8 @@ receivers:
     host: localhost
     port: 18080
     intervalSeconds: 1
+processors:
+  batch:
 
 exporters:
   otlp:
@@ -16,4 +18,5 @@ service:
     metrics:
       receivers:
         - smartagent/collectd_apache
+      processors: [batch]
       exporters: [otlp]