This repository has been archived by the owner on Oct 17, 2020. It is now read-only.
Add basic structure for search short link #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 50.03% 50.03%
=======================================
Files 123 123
Lines 2650 2650
Branches 147 147
=======================================
Hits 1326 1326
Misses 1274 1274
Partials 50 50
Continue to review full report at Codecov.
|
magicoder10
suggested changes
Jun 3, 2020
magicoder10
suggested changes
Jun 3, 2020
magicoder10
approved these changes
Jun 3, 2020
magicoder10
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior ( Optional for new feature )
Description
A RESTful API for users to search their short link is an important feature of Short, as such this feature should be done right. For more detailed discussion please find it in issue #260.
New Behavior
Description
The branch search-prototype implements the core of this feature as described in the document Search Short Link Design Doc but without the HTTP routing and authenticating. Opening a PR for that branch would be a rather larger PR (around 1K LoC) and tedious to review, that's why I will split it in smaller PRs going top-down and modify it along the way.
The first PR presents the public types and functions of the Search API.